Hi,
On Sun, 17 Feb 2008, Edgar Toernig wrote:
> Junio C Hamano wrote:
> >
> > + FILE *outto = (pager_in_use() ? stdout : stderr);
> > +
> > vsnprintf(msg, sizeof(msg), err, params);
> > - fprintf(stderr, "%s%s\n", prefix, msg);
> > + fprintf(outto, "%s%s\n", prefix, msg);
> >
> > What do people think? Have I overlooked any downsides?
>
> Wouldn't it be better/safer to redirect stderr to the pager
> in the first place?
>
> [...]
>
> /* return in the child */
> if (!pid) {
> dup2(fd[1], 1);
> + dup2(fd[1], 2);
> close(fd[0]);
> close(fd[1]);
> return;
> }
I like it.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
