There was a goto, and while it is not half as harmful as some people believe, it was unnecessary here. So remove it for readability. Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> --- http-push.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/http-push.c b/http-push.c index 93bd87d..4862db6 100644 --- a/http-push.c +++ b/http-push.c @@ -2404,12 +2404,9 @@ int main(int argc, char **argv) } while (request_queue_head && !aborted); /* Update the remote branch if all went well */ - if (aborted || !update_remote(ref->new_sha1, ref_lock)) { + if (aborted || !update_remote(ref->new_sha1, ref_lock)) rc = 1; - goto unlock; - } - unlock: if (!rc) fprintf(stderr, " done\n"); unlock_remote(ref_lock); -- 1.5.4.1.1353.g0d5dd - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html