Re: [PATCH] builtin-checkout: use struct lock_file correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 14 Feb 2008, Johannes Schindelin wrote:

> A lock_file instance must not be cleaned up, since an atexit() handler
> will try to access even correctly committed lock_files, since it has
> to make sure that they were correctly committed.

I think the lock_file API changed between when I wrote this code (using 
other code as reference) and now; could you check that there aren't other 
things I have to change as well, since I think you were following the 
lock_file changes at the time, and I wasn't? I got the most obvious one 
(calling close() on the fd yourself is no longer right, but I didn't know 
about this one, and I don't know about any further ones, if there are 
any.)

	-Daniel
*This .sig left intentionally blank*
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux