Junio C Hamano <gitster@xxxxxxxxx> writes: > Except that I'll reorder the patches so that > > (1) this test comes first, but with test_expect_failure instead; > > (2) then your earlier fix patch, but with a change that changes > the test_expect_failure to test_expect_success. > > Thanks. > > Perhaps it would be a good idea to require fix-up patches to > always come with a test case to prevent future regression. Perhaps we should add this hint to SubmittingPatches, on top of your additions? And to t/README? -- Jakub Narebski Poland ShadeHawk on #git - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html