Re: [StGit PATCH 2/2] Emacs mode: delete patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2008-02-11 10:42:22 +0100, David Kågedal wrote:

> Karl Hasselström <kha@xxxxxxxxxxx> writes:
>
> > David, could you have a look at this as well? In addition to me
> > being elisp challenged, there are the following issues:
> >
> >   * Is "d" a reasonable binding? Any better suggestion?
>
> We could reserve "d" for moving a patch "down", maybe. The more
> destructive commands could be on less accessible keys. Maybe "D" or
> "C-d".

I'll take "D" then, since control bindings are more likely to collide
with existing bindings (as is already the case with C-r for stg
repair).

> >   * Currently, this command requires you to mark one or more
> >     patches before deleting. This is convenient when deleting more
> >     than one patch, but one could argue that it should be possible
> >     to delete the patch at point without having to select it.
>
> You need something like this:

OK, thanks. I'll whip up a proper patch tonight -- unless you prefer
to do it yourself?

> >   * We should probably ask for confirmation before deleting.
>
> Absolutely. Something like this (untested):

Thanks again.

-- 
Karl Hasselström, kha@xxxxxxxxxxx
      www.treskal.com/kalle
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux