Jakub Narebski <jnareb@xxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> * jc/submittingpatches (Sun Feb 3 17:02:28 2008 -0800) 3 commits >> + Documentation/SubmittingPatches: What's Acked-by and Tested-by? >> + Documentation/SubmittingPatches: discuss first then submit >> + Documentation/SubmittingPatches: Instruct how to use [PATCH] >> Subject header >> >> These I think are sensible but they did not see much discussion, >> so they are parked here for now. > > I thing first and last are good to go, while second could get > improved. This means I guess either resending second patch for further > discussion, or adding it as is, and wait for further improvements; it > is better than nothing. Ok. As you can see above it's already merged to 'next', so here is an update with pieces taken from my earlier response to your question. -- >8 -- [PATCH] Documentation/SubmittingPatches - a suggested patch flow Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> --- Documentation/SubmittingPatches | 35 +++++++++++++++++++++++++++++++++++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 0661293..0e155c9 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -230,6 +230,41 @@ to modify. "Tested-by:" says the patch was tested by the person and found to have the desired effect. ------------------------------------------------ +An ideal patch flow + +Here is an ideal patch flow for this project the current maintainer +suggests to the contributors: + + (0) You come up with an itch. You code it up. + + (1) Send it to the list and cc people who may need to know about + the change. + + The people who may need to know are the ones whose code you + are butchering. These people happen to be the ones who are + most likely to be knowledgeable enough to help you, but + they have no obligation to help you (i.e. you ask for help, + don't demand). "git log -p -- $area_you_are_modifying" would + help you find out who they are. + + (2) You get comments and suggestions for improvements. You may + even get them in a "on top of your change" patch form. + + (3) Polish, refine, and re-send to the list and the people who + spend their time to improve your patch. Go back to step (2). + + (4) The list forms consensus that the last round of your patch is + good. Send it to the list and cc the maintainer. + + (5) A topic branch is created with the patch and is merged to 'next', + and cooked further and eventually graduates to 'master'. + +In any time between the (2)-(3) cycle, the maintainer may pick it up +from the list and queue it to 'pu', in order to make it easier for +people play with it without having to pick up and apply the patch to +their trees themselves. + +------------------------------------------------ MUA specific hints Some of patches I receive or pick up from the list share common - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
