"Marco Costalba" <mcostalba@xxxxxxxxx> writes: > On Feb 10, 2008 3:36 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > ... >> I do recall pointing out that a rather common "format:%an <%ae>" >> ends up parsing the same line twice, and mentioned we may want >> to memoise the first call's result in the format_commit_context >> structure, but what else did I suggest??? >> > > Please read thread: "[PATCH RESEND] Avoid a useless prefix lookup in > strbuf_expand()" > > you will find your suggestions and following answers. Yeah, I mentioned the comment needing to be adjusted (which you did in this round), asked a minor question about the code (you answered in the thread), besides pointing out that a rather common "format:%an <%ae>" being inefficient (which you brushed aside, claiming that is a special case). I've touched-up a few typoes and style glitches and will park this on 'pu' for now. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
