Re: [PATCH] Add gitattributes file making whitespace checking pickier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 09, 2008 at 09:22:00PM +0100, Jakub Narebski wrote:
> J. Bruce Fields wrote:
> > On Sat, Feb 09, 2008 at 11:36:31AM -0800, Jakub Narebski wrote:
> > > "J. Bruce Fields" <bfields@xxxxxxxxxxxx> writes:
> > > 
> > > >  gitweb/gitweb.perl                                  |  566 ++--
> > > >  index-pack.c                                        |   30 
> > > 
> > > gitweb (at my insistence) uses tabs for indent, but spaces for align,
> > > so that the layout is [roughly] preserved independently of the tab
> > > size. IMHO it is superior style, but much harder to check
> > > algorithmically (although I send some sketch of idea how to check that
> > > at least for aligned commands). That is why there is such a big change.
> > > 
> > > I'd rather have real bugfixes, real documentation improvements, new
> > > features instead of such bikeshedding.  If someone is making a change
> > > somewhere, he/she can fix the whitespace in the neighbourhood.
> > 
> > I agree completely.  Did I suggest otherwise?
> 
> Ah, sorry, I have misunderstood.
> 
> This is an informational piece, then, isn't it?

Yeah, I was generating the diff just as a way to get an idea which paths
which policies should apply to.

That still doesn't rise much above bikeshedding, but it's not quite as
bad as actually trying to apply such a diff...

--b.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux