Re: [PATCH] http.c: guard config parser from value=NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Govind Salinas" <blix@xxxxxxxxxxxxxxxxx> writes:

> Signed-off-by: Govind Salinas <blix@xxxxxxxxxxxxxxxxx>
> ---
>  http.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/http.c b/http.c
> index d2c11ae..0a2c1c8 100644
> --- a/http.c
> +++ b/http.c
> @@ -92,6 +92,9 @@ static void process_curl_messages(void)
>
>  static int http_options(const char *var, const char *value)
>  {
> +	if (!value)
> +		return git_default_config(var, value);
> +
>  	if (!strcmp("http.sslverify", var)) {
>  		if (curl_ssl_verify == -1) {
>  			curl_ssl_verify = git_config_bool(var, value);

I think this patch is wrong.

You just broke existing repositories with:

	[http]
        	sslverify

to set it to true.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux