Since exec_cmd.c changed (511707d42b3b3e57d9623493092590546ffeae80) to
just use the PATH variable for finding Git binaries, the daemon has been
broken for people with picky inetds (such as the OpenBSD one) which
launder the environment on startup. The result is that the daemon
mysteriously fails to do anything useful.
One line fix: call setup_paths() in main before doing anything.
Signed-off-by: Mark Wooding <mdw@xxxxxxxxxxxxxxxx>
---
daemon.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
I've not addressed the other problem with git-daemon which this
bug brought to my attention, which is that it doesn't log any
kind of error if it fails to exec.
diff --git a/daemon.c b/daemon.c
index 41a60af..cfd6124 100644
--- a/daemon.c
+++ b/daemon.c
@@ -1149,6 +1149,7 @@ int main(int argc, char **argv)
usage(daemon_usage);
}
+ setup_path(NULL);
if (inetd_mode && (group_name || user_name))
die("--user and --group are incompatible with --inetd");
--
1.5.4.rc5.5.gab98-dirty
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
