On Fri, Feb 08, 2008 at 05:34:24PM +0100, Michele Ballabio <barra_cuda@xxxxxxxxxxxx> wrote:
> On Friday 08 February 2008, Miklos Vajna wrote:
> > diff --git a/setup.c b/setup.c
> > index adede16..361825f 100644
> > --- a/setup.c
> > +++ b/setup.c
> > @@ -346,13 +346,13 @@ int git_config_perm(const char *var, const char *value)
> > {
> > if (value) {
> ^^^^^
> value is already checked here. No need to check further.
ah, i missed it. should we add some comment about this or just it wasn't
obvious to me only? (same true to the other patch where you pointed out
the check was not necessary)
thanks,
- VMiklos
Attachment:
pgpAOPoDNGOHK.pgp
Description: PGP signature
