On Wed, 6 Feb 2008, Stephen Sinclair wrote: Please provide attribution (who write what) when quoting, like below: > Jakub Narebski wrote: >> "Stephen Sinclair" <radarsat1@xxxxxxxxx> writes: >>> Attached is a script I quickly wrote up yesterday. Sometimes I've >>> found I started working only to realize I was on the wrong branch. >>> (Now that I'm accustomed to working with git, I make many small >>> branches, so it happens.) >> >> First, it is much better to put such script inline, in the body of >> your email. This makes commenting about script body much easier. >> And if you have to attach it, for example because your mailer mangles >> whitespace (which is not the case here), make sure that attachement >> uses "text/plain", and if possible "inline" disposition, to better >> _view_ the code without need to save it to temporary file. >> >> I would take an exeption and comment on your code, even though you >> make it hard to do so. > > Thank you. Since there's already a solution for this in contrib, > (didn't see it, sorry), I'll just take your recommendations on coding > style for any future stuff I do. First, the code in contrib doesn't do all your code did. It doesn't show if workarea is "dirty" (although I'm not sure if this is very useful), nor does it show number of commits since or to mainline (origin) version, although with working on (with) feature/topic branches which does not have corresponding remote tracking branch it seems not useful. On the other hand code in _git_ps1 (taken from one of the "git prompt" posts floating on git mailing list, and available in archives, together with /usr/share/stgit/contrib/stgbashprompt.sh from StGit, Quilt-like patch management layer on top of Git) shows also name of repository and path in repository, and also if the branch is managed by StGit. Second, I think you have learned something. Both on rules regarding discussion, netiquette and sending contributions on this mailing list, and about how to write scripts for/around git. (At least I hope so). -- Jakub Narebski Poland - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
