Re: [PATCH] Make git prune remove temporary packs that look like write failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nicolas Pitre wrote:
> On Tue, 5 Feb 2008, David Steven Tweed wrote:
> 
>> @@ -115,5 +139,6 @@ int cmd_prune(int argc, const char **argv, const char
>> *prefix)
>>
>>  	sync();
>>  	prune_packed_objects(show_only);
>> +	remove_temporary_files();
> 
> Maybe you could implement the "show_only" mode for 
> remove_temporary_files() as well?  Otherwise the -n option would not be 
> respected.

I also suggest taking a look at the functions in builtin-prune-packed.c to see
how similar functions are implemented there.

Use strlcpy instead of sprintf.
Use prefixcmp instead of strncmp.
Use same messages as prune_dir() for show_only path and unlink failure.
You could also check the opendir call and print a suitable message on failure.

-brandon

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux