Re: [PATCH-v2 4/4] git-commit: add a prepare-commit-msg hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin wrote:
Hi,

On Tue, 5 Feb 2008, Paolo Bonzini wrote:

The hook is not suppressed by the --no-verify option, and the
exit status is ignored by git.

Umm. Should the exit status really be ignored? What _use_ would it be then?

None; in the previous version I used an exit status of 1 to kill the commit. But since this hook, unlike others, is meant to prepare things for the user, the hook itself was not suppressed by --no-verify, only checking the exit status. Junio thought it was a mess, so I now completely ignore the exit status.

I just wrote the above sentence because prepare-commit-msg is the only git-commit hook whose exit status is ignored.

Paolo
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux