Hi,
On Mon, 21 Jan 2008, Paolo Bonzini wrote:
> +static int run_hook(const char *index_file, const char *name, ...)
> +{
> + struct child_process hook;
> + const char *argv[10], *env[2];
> + char index[PATH_MAX];
> + va_list args;
> + int i;
> +
> + va_start(args, name);
> + argv[0] = git_path("hooks/%s", name);
> + i = 0;
> + do {
Here, an
if (++i >= ARRAY_SIZE(argv))
die ("run_hook(): too many arguments");
is missing. Even nicer, you could have
int argc = 1;
char **argv = malloc(sizeof(*argv) * 2);
and
if (++i >= argc)
argc = ALLOC_GROW(argv, i + 1, argc);
in the loop. Of course, you would have to change the "++i" to "i" in this
line:
> + argv[++i] = va_arg(args, const char *);
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
