Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > On Sun, 3 Feb 2008, Junio C Hamano wrote: > > > "Lars Hjemli" <hjemli@xxxxxxxxx> writes: > > > > > Maybe this as a compromise? > > > > > > static char buf[PATH_MAX + 9]; /* "GITDIR: " + "\n" */ > > > ... > > > if (!len || buf[len - 1] != '\n') > > > return NULL; > > > buf[len - 1] = '\0'; > > > if (prefixcmp(buf, "GITDIR: ")) > > > return NULL; > > > > Perhaps that is easier to read. > > > > For now I haven't picked up any of the "how about this way" > > revisions. > > Yeah, I think all my comments have been addressed... Lars, care to send a > new version? I would suggest a slightly different name, "GIT_DIR: ", as the line prefix, because the environment variable is also GIT_DIR. But that's just me. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
