On Fri, 01 Feb 2008 17:03:04 -0800
Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Sean <seanlkml@xxxxxxxxxxxx> writes:
> >
> > + if (!rs[i].dst)
> > + rs[i].dst = xstrdup("");
>
> I haven't followed the codepath carefully before responding, it
> feels like sweeping the breakage under the carpet, without
> fixing the real issue.
>
> If the problem is a badly formatted input, shouldn't the code
> die loudly with diagnostic message, instead of pretending as if
> the user said something different (and sensible), especially
> without telling the user that that is what the code is doing?
>
Hey Junio,
You're probably right. It seemed like a reasonable fix at the time
without having to understand the code too deeply. With the above
patch, the code does complain to the user:
$ git-fetch ../repo refs/heads/* :refs/heads/*
fatal: * refusing to create funny ref 'floop' locally
But surely a better error could be shown if fetch is made to
squawk whenever a destination ref is omitted. I just wasn't
confident enough in the code, or in knowing what refspec rules
are universally applicable.
Sean
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
