Jeff King <peff@xxxxxxxx> writes: > ... then for every 12345678* that we don't have, we will claim > the correct abbreviation is 1234568. > > In practice, I doubt this is a problem. > > But getting back to your point: yes, I agree it is a little ugly. > Rewriting find_unique_abbrev would be necessary for fixing it, and I'm > not sure it is worth the trouble. I think that needs to be done carefully. I recall some callers do expect it to return NULL for nonexistant objects, so the bug you noted above as "rare case" may need to be fixed, which I think is more important than coming up with a potentially too short abbreviation. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
