Brandon Casey wrote:
Johannes Schindelin wrote:
Hi,
On Wed, 30 Jan 2008, Brandon Casey wrote:
This command requires a revision to be specified on the command line, so
remove '--default HEAD' from the arguments to git rev-list. They are
unnecessary.
But I thought that you wanted "git filter-branch --msg-filter=rot13" to
work on HEAD by default?
I do. But isn't that inconsistent with "git filter-branch" does _not_ work
on HEAD by default and instead prints out usage information?
If I do:
git filter-branch -d /tmp/git_temp
and it is successful, I think I would also expect this to succeed:
git filter-branch
So, I think the "operates on HEAD" by default is consistent with what other
git tools do, but I think it is not consistent for filter-branch to sometimes
operate on HEAD by default and sometimes error with usage information.
Well, if there's no filter specified it has nothing to do, so erroring out
in the no-arguments-at-all case would be sensible.
OTOH, it would be better to error out for the no-filter case explicitly,
which would also cause the no-arguments case to error out.
--
Andreas Ericsson andreas.ericsson@xxxxxx
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
