On Tue, Jan 29, 2008 at 05:45:58PM -0500, Jeff King wrote:
> > if (rename_dst_nr > rename_limit && rename_src_nr > rename_limit)
> > goto cleanup;
>
> Hrm, yes, I think it can still overflow. (e.g., a 2 by 2^32-1
> situation). But changing it to || isn't right, either; you would
I think the correct solution is just:
/* check for overflow of square */
if (rename_dst_nr > ULONG_MAX / rename_src_nr)
goto cleanup;
-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
