On Mon, Jan 28, 2008 at 05:25:31PM -0800, Junio C Hamano wrote: > Heh, that's aonly a week ago but already you need to dig almost > 500 messages back to get there. That MacOSX thread really > killed our human performance. > > [1/3] is Ok, probably even for 1.5.4. > > [2/3] The use of "test -e" slightly ticked my compatibility > worry (instead use "test -f" or "test -d" when able) but non > prehistoric POSIX systems should grok it just fine these days. > > [3/3] as you said was questionable in its introduction of a flag > that used primarily for testing. Since the whole point of [2/3] > is to make [3/3] possible, I was inclined to put both on hold. That all sounds reasonable. I will rebase and resubmit after 1.5.4, with 2/3 using "test -f" and 3/3 matching Gustaf's fix (and 1/3 included if you do not apply it beforehand). Thanks for the response. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html