On 1/25/08, Karl Hasselström <kha@xxxxxxxxxxx> wrote: > On 2008-01-24 15:27:17 -0500, Jon Smirl wrote: > > > If I import a series of patches from one of my trees into another, > > stgit preserves the signed-off-by lines like you would expect it to. > > When I export these patches it adds a signed-off-by line for myself > > again like you would expect it to. But adding this line on export > > needs to checks and make sure that my name isn't already in the > > signed-off-by list, without this check I have to manually remove my > > name when it gets duplicated. > > What command are you using to export patches? I am using "stg export" from one branch and then "stg import -s" on another. After I import the patch and do 'stg edit' on it, it has the signed-off-by line in it. When it is export from that branch the signed-off-by get added again. You don't want to strip the signed-off-by lines on import, they may be from other people. I would think that on export you could look and see if my signed-off-by line is already on the patch before adding it again. I might be able to handle this better by rebasing my master from both linus/master and my branch containing these i2c patches that are taking so long to get in. That would avoid the import/export step. But then I can't edit the patches directly on my master branch. > > IIRC, all commands that have --sign and --ack flags already to check > for duplicates. But if you do something like have your sign-off line > in the template the export command uses, that would lead to > duplicates. > > -- > Karl Hasselström, kha@xxxxxxxxxxx > www.treskal.com/kalle > -- Jon Smirl jonsmirl@xxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
