"H. Peter Anvin" <hpa@xxxxxxxxx> writes: > Junio C Hamano wrote: >> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >> >>> FWIW we had the same problem in MinGW, and Hannes Sixt solved it: >>> >>> http://repo.or.cz/w/git/mingw/j6t.git?a=commitdiff;h=b8e84a68f01a2386b2071e1bdc8e24de809a3f6d >>> >>> That might give you an idea how to solve the issue. Maybe you even >>> make a git patch out of it? With a Makefile variable >>> BROKEN_SNPRINTF=YesPlease, maybe? >> >> Hmmm. Looking at that change makes me wonder if that solution >> is Kosher. The value of the va_list you pass to vsnprintf() is >> unspecified after the call. >> >> It may be Ok as mingw-only "compatibility wrapper", but I think >> you have to be a bit careful. It is not a general solution for >> any BROKEN_SNPRINTF. > > That's what va_copy() is for. Yes. See 4bf53833dbca666f61b5177977e96d453527db20 ;-) - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
