Re: [PATCH] contrib/hooks/post-receive-email: add a From: line to the email header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Nov 8, 2007, at 10:55 AM, Junio C Hamano wrote:

Gerrit Pape <pape@xxxxxxxxxxx> writes:

$committer is already extracted from the latest existing rev, so add the
corresponding From: line to the email header.

You may fight this out with Andy if you want to, but I think I'd
side with the existing behaviour.

commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b
Author: Andy Parkins <andyparkins@xxxxxxxxx>
Date:   Fri Sep 28 15:24:26 2007 +0100

post-receive-hook: Remove the From field from the generated email header so that the pusher's name is used

    Using the name of the committer of the revision at the tip of the
updated ref is not sensible. That information is available in the email
    itself should it be wanted, and by supplying a "From", we were
effectively hiding the person who performed the push - which is useful
    information in itself.

    Signed-off-by: Andy Parkins <andyparkins@xxxxxxxxx>
    Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>


Hi guys,
the problem with this change is that when one uses Gitosis all the commits are pushed with the `git' user so emails always appear to come from git@fqdn. I guess it would be worth to add an option to retain the old behavior (where $committer was extracted from the last commit pushed and used in the `From' field), don't you think?

--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux