On Mon, Jan 21, 2008 at 08:57:46PM +0100, Gustaf Hendeby wrote: > This fixes the subtile bug in git send-email that was introduced into > git send-email with > > commit aa54892f5ada8282643dc7387b33261c7135d784 > send-email: detect invocation errors earlier Sorry, this was my fault. I have looked over the code again to make sure there are not any other places where the movement of @files should matter, but this seems to be the only one. As penance, I'll send some tests in a moment. > - @files = ($compose_filename . ".final"); > + @files = ($compose_filename . ".final", @files); I think this might be more readable as unshift @files, "$compose_filename.final"; but either way it fixes the bug, so Acked-by: Jeff King <peff@xxxxxxxx> -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
