Hi, On Mon, 21 Jan 2008, Mark Junker wrote: > Use FIX_UTF8_MAC to enable conversion from UTF8-MAC to UTF8 for readdir > and get_pathspec. > > I had to change get_pathspec too because otherwise git-add wouldn't work > anymore because it uses the output of get_pathspec as strings to compare > with the output of readdir. > > I'm quite unsure because this is my first patch for the git project and > I have several questions: > > 1. Is FIX_UTF8_MAC the right name for this "feature"? > 2. Do I have to introduce a configuration option for this "feature"? > > Signed-off-by: Mark Junker <mjscod@xxxxxx> I hate three facts about this patch: - it is too specific to the MacOSX filesystem issues (and better alternatives have _already_ been proposed), - it is a new feature and not a bug fix, very, _very_ late in the rc cycle, - it contains questions in the commit message? WTF? Should it not be marked as PATCH/RFC, possibly without a signoff to make sure that you want to discuss it first? It's possible I am grumpy because everybody and her dog seems to work on her little projects, while I listen to Junio and try to work with/on "master" already since a month. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
