Re: [PATCH] git-fsck: report missing author/commit line in a commit as an error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, 20 Jan 2008, Martin Koegler wrote:

> +	if (!commit->date)
> +		return objerror(&commit->object, "invalid author/commiter line in %s",

s/commiter/committer/

It makes me wonder, though, if that's correct.  AFAICT it is the committer 
date, and the rest of the line _might_ be just fine.

Why not be less intrusive and just change the printf() into a return 
objerror(), like the commit message suggests?

Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux