On Fri, Jan 18, 2008 at 12:39:45PM -0500, Jay Soffian wrote: > > + return "patch contains line longer than 998 characters"; > How about offering the line number. e.g.: > > return "patch line number $. is longer than 998 characters"; I think that is sensible (Junio, if you apply pre-1.5.4, can you mark it up? Otherwise I will put it in the post-1.5.4 resend). > > +test_expect_success 'no patch was sent' ' > > Shouldn't that be "no patches were sent" to match the perl output? It's purely an informational message for the test script output, so it doesn't matter. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html