Junio C Hamano <gitster@xxxxxxxxx> wrote: > Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > > > We also move the assignment of -1 to the lock file descriptor > > up, so that rollback_lock_file() can be called safely after a > > possible attempt to fclose(). This matches the contents of > > the 'if' statement just above testing success of fdopen(). > > > > Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx> > > --- > > Shawn, could you lend an extra set of eyeballs on this one > please? It looks sane to me but obviously you are more familiar > with the code. I agree. Acked-by: Shawn O. Pearce <spearce@xxxxxxxxxxx> -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html