Re: [PATCH v2] Do not show "diff --git" metainfo with --no-prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 17 Jan 2008, Jeff King wrote:

> On Thu, Jan 17, 2008 at 09:49:14AM -0500, Jeff King wrote:
> 
> > Hmm. I happen to set my "meta" color to something a little less 
> > attention-grabbing (magenta), and I find the alternate coloring to be 
> > a nice visual indicator of "nothing happened on this line". I can see 
> > how bold would be very distracting, though. Perhaps there should be a 
> > color.diff.unimportant?
> 
> BTW, here is the fix to at least color it as plain (it is a little 
> larger than the one line it needs to be because it cleans up the 
> variable name "set", which is what caused this confusion in the first 
> place).

Ah, that explains it!  Your patch looks good to me.

Thanks,
Dscho

P.S.:

> @@ -586,7 +587,6 @@ static void fn_out_consume(void *priv, char *line, unsigned long len)
>  	}
>  
>  	if (len < ecbdata->nparents) {
> -		set = reset;
>  		emit_line(reset, reset, line, len);
>  		return;
>  	}

I wonder what I wanted to achieve with that ;-)

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux