On Tue, Jan 15, 2008 at 03:11:07PM -0800, Junio C Hamano wrote: > Dmitry Potapov <dpotapov@xxxxxxxxx> writes: > > > So, please, consider it for inclusion as a bug fix. > > Somebody has to go back to the "git log" output and the list > archive to see if you two did not forget other ramifications, > because I vaguely recall this 1% thing was done for a reason and > Linus had a very good argument (at least back then the argument > sounded very good to me) supporting the deliberate difference > between the two "binary" heuristics. First of all, my patch does not make them being the same, it just makes one being stricter than the other, and I explained why it is the tight thing to do. Second, it is difficult for me to find to what particular words of Linus *you* refer to. However, if it is something like this post: http://article.gmane.org/gmane.comp.version-control.git/39618 Then it seems to me, Linus sounded more in favor of that change than against it. His main argument was against 'diff' heuristic, which he felt was not strict enough for CRLF translation: "It's *much* better to miss some CRLF translation than to do too much of it." Dmitry - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
