しらいしななこ <nanako3@xxxxxxxxxxxxxx> writes: > You are calling overlay_tree_on_cache() which does use CE_UPDATE flag to mark > duplicate entries. And that is the same algorithm as used when git-ls-files > is called with its --with-tree option. I think this if statement is not > mindless but is the right thing to have the same logic as you have in > git-ls-files. You are right and I was stupid. Because the pathname ce->name is given to path_list_insert() which does not allow duplicates, there is no breakage either way from the correctness point of view in this codepath, unlike the one in ls-files. But avoiding unnecessary processing with a single bit check is certainly better. Will revert, but I first have to go find a brown paper bag. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
