On Jan 14, 2008, at 7:40 AM, Dmitry Potapov wrote:
On Mon, Jan 14, 2008 at 07:17:26AM +0100, Steffen Prohaska wrote:
Your traces reveal that it is a racy condition that can trigger
the double warnings.
It is not a racy condition. It is just another branch in the
code, which happens when an existing file is modified. Your
tests always added a new file, so they could not reproduce
the problem.
Do you have a test case that reliably triggers the second call to
convert_to_git()?
===========================================
git config core.autocrlf input
echo Hello > foo
git add foo
git commit -m 'add foo'
echo Hello >> foo
unix2dos foo
# This should trigger double crlf warning
git add foo
===========================================
Yes, this reproduces the problem.
Thanks,
Steffen
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
