On Jan 13, 2008 3:25 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > "Ping Yin" <pkufranky@xxxxxxxxx> writes: > > >> + echo "* $name $sha1_src...$sha1_dst:" > > > > If it's a type change (head submodule but index blob, or the the > > reverse), $sha1_dst or $sha1_src will be the sha1 of the blob. It's > > inapprociate to be shown as if it's a commit in the submodule. May > > 00000000 should be shown instead of the blob sha1? > > I do not think that adds much value. When A or B is a > non-commit, you know that A...B notation does not apply, and > because it is probably a rare situation you would want to make > it even more clearer to the reader by using a different > notation. Like > > echo "* $name have changed from submodule $sha1_src to blob $sha1_dst!!". > > perhaps in red bold letter in larger font ;-) > OK, i will think over. -- Ping Yin - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
