Re: [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit summary size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 12, 2008 4:36 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Ping Yin <pkufranky@xxxxxxxxx> writes:
>
> > @@ -265,6 +267,10 @@ set_name_rev () {
> >  #
> >  modules_summary()
> >  {
> > +     summary_limit=${summary_limit:-1000000}
>
> Why a million?
Because i think a million is big enough. I'd better define a constant
for unlimited number.
>
> > +     summary_limit=$((summary_limit<0?1000000:summary_limit))
>
> This is doubly bashism.  Variables must be referenced with $,
> and $(( conditional ? iftrue : iffalse )) is not POSIX.
>
Ok, i'll fix this.


-- 
Ping Yin
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux