Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Robin Rosenberg escreveu:
I pushed my doc-branch as pu, you can look at it. My intention is take a look again
and then push it as master if there are no objections. Is it ok and good to flags public stuff without javadoc as an error (tip pu commit)?

The abbr commit patch is already pushed to master.
Looks good to me. You actually took some time to explain things, it will be usefull, thanks! If we really want to document all the public methods then I think it's nice to flag it's absence as an error. It would have made me document GitResourceNode.getContentIdentifier(), it's now one more comment for you to add before pushing to master ;)

[]s,
Roger.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux