Hi, On Thu, 10 Jan 2008, Junio C Hamano wrote: > In this case, a failure while closing that small .keep file is highly > unlikely, and if we ever mange to trigger such a highly unlikely > failure, I think we would rather want to *know* about it, as it is > likely there is something more seriously wrong going on. > > So let's keep that check on close(). My comment was not about that _check_, but about having this die() instead of just printing out a warning. If that close fails, strange things are going on, alright. But neither the open() nor the write() failed at that point, so IMO it would be a mistake to error out _here_. If later stages fail also, well, we can die() there, no? Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
