On Jan 9, 2008 4:24 PM, Lars Hjemli <lh@xxxxxxxxxxxxxxxxx> wrote: > On Jan 9, 2008 10:51 AM, Imran M Yousuf <imyousuf@xxxxxxxxx> wrote: > > On Jan 9, 2008 2:59 PM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote: > > > > > > - Previously, passing --cached to add, init, or update was an error, now > > > it is not. > > > > The usage statement and this behaviour is rather contradicting. The > > usage says that --cached can be used with all commands; so I am not > > sure whether using --cached with add should be an error or not. IMHO, > > if the previous implementation was right than the USAGE has to be > > changed, and if the previous implementation was incorrect, than if the > > default command is set to status than current implementation is right. > > > > I would like to get comment on this until I fix the patch and resend it. > > --cached only makes sense for the status subcommand, so the > usage/manpage probably should have looked like this (except for the > whitespace mangling...): > > diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt > index cffc6d4..331e806 100644 > --- a/Documentation/git-submodule.txt > +++ b/Documentation/git-submodule.txt > @@ -10,7 +10,10 @@ SYNOPSIS > -------- > [verse] > 'git-submodule' [--quiet] [-b branch] add <repository> [<path>] > -'git-submodule' [--quiet] [--cached] [status|init|update] [--] [<path>...] > +'git-submodule' [--quiet] [--cached] [status] [--] [<path>...] > +'git-submodule' [--quiet] init [--] [<path>...] > +'git-submodule' [--quiet] update [--] [<path>...] > + > This change makes a lot sense. Thus I will make sure that it is used in this manner :). Thanks a lot for clarifying it Lars. I wanted to know what is the purpose of '--'? If it is simply meant to be a separator than fine; else I would be grateful if you would please explain its purpose, so that I do not again implement wrongly :). > > COMMANDS > -- > 1.5.3.7.1141.g4eb39 > -- Imran M Yousuf - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
