Hi Junio, Firstly, $add is still used later in the code. Secondly, yes the variables should be deleted. Will make the change and send the patch again; I forgot to clean the unused variables from the declaration, sorry. Best regards, Imran On Jan 9, 2008 2:19 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > imyousuf@xxxxxxxxx writes: > > > diff --git a/git-submodule.sh b/git-submodule.sh > > index ad9fe62..8a29382 100755 > > --- a/git-submodule.sh > > +++ b/git-submodule.sh > > @@ -16,6 +16,7 @@ update= > > status= > > quiet= > > cached= > > +command= > > Doesn't the patch make some if not all of the above variables > unused? > > > case "$1" in > > add) > > add=1 > > + command="module_$1" > > ;; > > init) > > - init=1 > > + command="modules_$1" > > ;; > > Does the remaining code still use $add? > -- Imran M Yousuf - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
