Junio C Hamano schrieb:
> Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes:
>> @@ -19,7 +19,10 @@ int recv_sideband(const char *me, int in_stream, int out, int err)
>> {
>> unsigned pf = strlen(PREFIX);
>> unsigned sf = strlen(SUFFIX);
>> - char buf[pf + LARGE_PACKET_MAX + sf + 1];
>> + char *buf, *save;
>> +
>> + save = xmalloc(sf);
>> + buf = xmalloc(pf + LARGE_PACKET_MAX + sf + 1);
>
> I have to wonder if the malloc() overhead is small enough
> compared to the network bandwidth to make a two malloc-free
> pairs per packet a non-issue...
recv_sideband() is called _once_per_connection_ and not for each packet.
Hence, these two mallocs should not concern us.
-- Hannes
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
