On Sat, Jan 05, 2008 at 03:11:37PM +0100, Matthias Kestenholz wrote: > --- a/builtin-branch.c > +++ b/builtin-branch.c > [...] > -static int branch_use_color; > [...] > if (!strcmp(var, "color.branch")) { > - branch_use_color = git_config_colorbool(var, value, -1); > + git_use_color = git_config_colorbool(var, value, -1); > return 0; > } If I read this right, you are getting rid of the individual "use color" variables with a single static git_use_color. This will break if two different color "zones" get used in the same program (e.g., color.branch and color.diff, but only one is supposed to be set). I don't think this is a problem currently, but it seems like a step backwards in terms of libification. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html