On Sun, Jan 06, 2008 at 01:22:57PM -0800, Junio C Hamano wrote: > Yes, to a certain extent with Perl (I think if you make the same > typo twice you won't get much help, and that is quite easy to > trigger with variable name autocompletion and cut-and-paste). Yes, and a static checking language would be a little less error-prone. But who can live without "eval <STDIN>"? :) > I suspect "if (!$menu_use_color)" might need to be refined in > sub "highlight_prefix". It should be tied with $prompt_color > somehow (i.e. either it is undef or the "plain" color), > shouldn't it? I'm not sure. It avoids printing the brackets in "[p]atch". If you say "use color, but make the color plain" does that mean you want brackets or not (right now it will not show brackets)? > But other than that the result looks quite nice. I shuffled the > patches around and the resulting series consists of three patches: Great. That is the order I would have chosen as well (and hopefully I gave you enough material in the commit messages to cut and paste something sensible). -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
