Matthias Kestenholz <mk@xxxxxxxxxxx> writes: > I managed to throw something together which works and passes all > the tests. Documentation included. :-) Is it because we do not usually test colours and the tests run without terminals to make sure "color.* = auto" does not kick in? > I would be happy for feedback and suggestions. * Shouldn't "color.git = true" with "color.diff = false" mean "I want colour for everything by default but I do not want to see coloured diff"? * git_foo_config() callback from git_config() returns 0 on success; the API change needs to be documented to warn others. I haven't studied your patch very deeply so I may have misread what you tried to do, regarding the first point, though. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html