On Fri, Jan 04, 2008 at 03:59:34AM -0500, Jeff King wrote: > OK. In that case, we need a way for the plumbing to tell the diff > machinery "don't ever try loading the ui config." > > * funcname-pattern can go either way; that affects what appears > > at the end of @@ context @@ lines, and would not have risk to > > corrupt the patch for plumbing. I just sent a patch to put the funcname pattern in the "basic" config, and to get rid of the lazy config loading. So that fixes one call by the plumbing to read_config_if_needed. And it looks like the second call is already OK. We don't try parsing the config to get the external diff command unless ALLOW_EXTERNAL is set, which the plumbing already disallows (though I am still confused why it would need to be loaded lazily in the first place -- I wonder if read_config_if_needed is needed at all). -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
