Jeff King <peff@xxxxxxxx> writes: > I'm not sure what you mean here. Are you saying that it is the desired > behavior for "git-diff --color" to use my color.diff.* variables, but > for "git-diff-files --color" not to? What I meant is "git diff" without --color can be colorized because of config but we should never allow "git diff-files" without --color to be colorized by user's config. I realize that you were talking about the choice of colors, which is a different issue. I do not much care ;-), but I guess we would want to be consistent. > Not to mention the other bug (that diff-files _does_ read the config, > just halfway through). That one _is_ a bug. diff-files should not be affected by "diff.color = auto" or somesuch in the config, even when the user uses custom function header crap. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html