On Jan 2, 2008 10:02 PM, Steffen Prohaska <prohaska@xxxxxx> wrote: > > > On Jan 3, 2008, at 5:07 AM, Dmitry Kakurin wrote: > > > On Jan 1, 2008 10:52 AM, Steffen Prohaska <prohaska@xxxxxx> wrote: > >> In conclusion, using setenv() as in the original code instead of > >> set_git_dir() should be safe and this patch is not needed. > >> > >> I tend to revert the changes in msysgit and see if we hit any > >> problems. But I'll wait until 1.5.4 is released. > >> > >> Steffen > > > > Please don't revert this change. I've made it in response to git clone > > failing, commit 855f254b2b5b083a63fc8d7709a42e2cbdc5a136. > > I know. But I cannot reproduce the error. > > Do you have a test case that demonstrates the problem? > > I either want to see the patch upstream in official git or revert > it in msysgit. But I cannot answer the questions that were > raised after I sent the patch (see earlier in this thread). And > I can't see the problem that your patch solves, even after > spending some time on reading and instrumenting code. I remember that the problem was as simple as git clone or git clone --bare failing. Also I'm not sure if it matters but I'm running Vista. There is also a chance that code has changed since then and this problem went away. -- - Dmitry - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
