On Wed, 2 Jan 2008, Martin Koegler wrote: > > - old_commit = (struct commit *)parse_object(old_sha1); > - new_commit = (struct commit *)parse_object(new_sha1); > + old_object = parse_object(old_sha1); > + new_object = parse_object(new_sha1); I think it would be better to use old_object = lookup_commit_reference(old_sha1); if (!old_object) return "bad ref"; new_object = lookup_commit_reference(new_sha1); if (!new_object) return "bad ref"; which will write a slightly more useful error message if it's not a commit (ie it will use the "check_commit()" function in commit.c) Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
