Re: [PATCH] Remove duplication in t9119-git-svn-info.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> wrote:
> "David D. Kilzer" <ddkilzer@xxxxxxxxxx> writes:
> 
> > @@ -350,8 +355,8 @@ test_expect_success 'info unknown-symlink-directory' "
> >  	cd svnwc &&
> >  		ln -s unknown-directory unknown-symlink-directory &&
> >  	cd .. &&
> > -	ptouch gitwc/unknown-symlink-directory \
> > -	       svnwc/unknown-symlink-directory &&
> > +	ptouch svnwc/unknown-symlink-directory \
> > +	       gitwc/unknown-symlink-directory &&
> 
> Hmph.  Am I the only one who finds this repetition somewhat
> disturbing?

"David D. Kilzer" <ddkilzer@xxxxxxxxxx> wrote:
> Simplify arguments to ptouch bash function.

Not reading Junio's mind, I think he meant that you were swapping the
"gitwc/" and "svnwc/" args everywhere in your changeset.

Nevertheless, does your change make things work with older
versions of SVN?  I'm running 1.4.x everywhere these days, but
I seem to recall the version of SVN on kernel.org was giving
Junio trouble with the tests.

-- 
Eric Wong
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux