On 12/21/2007 02:34 PM, Jeff King wrote: > On Fri, Dec 21, 2007 at 12:36:42PM +0100, Gustaf Hendeby wrote: > >> - system($editor, $compose_filename); >> + system("$editor $compose_filename"); > > If you are going to do it that way, I suspect you want to quotemeta > $compose_filename. > > -Peff Generally that would be true, but is that really necessary when I know $compose_filename is defined as: my $compose_filename = ".msg.$$"; Or, should I take it that you prefer the version using split? I didn't really feel good about the possibility of splitting paths with spaces that came with that one though. /Gustaf - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html