Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > Anything wrong with that patch? > > http://article.gmane.org/gmane.comp.version-control.git/68444 I think Steven stopped after you poked holes in that patch. The way scripted commands spawned editor is: eval "${GIT_EDITOR:=vi}" '"$@"' which meant that $IFS characters in $GIT_EDITOR separated words and $environment_variables were substituted. IOW, this is possible: GIT_EDITOR='emacs -l $HOME/my-customization.el' I think something like this patch is probably more appropriate. It avoids potential bugs in splitting arguments by hand and lets the shell deal with the issue. --- builtin-tag.c | 14 +++++++++++++- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/builtin-tag.c b/builtin-tag.c index 274901a..fae2487 100644 --- a/builtin-tag.c +++ b/builtin-tag.c @@ -47,7 +47,19 @@ void launch_editor(const char *path, struct strbuf *buffer, const char *const *e editor = "vi"; if (strcmp(editor, ":")) { - const char *args[] = { editor, path, NULL }; + size_t len = strlen(editor); + int i = 0; + const char *args[6]; + + if (strcspn(editor, "$ \t'") != len) { + /* there are specials */ + args[i++] = "sh"; + args[i++] = "-c"; + args[i++] = "$0 \"$@\""; + } + args[i++] = editor; + args[i++] = path; + args[i] = NULL; if (run_command_v_opt_cd_env(args, 0, NULL, env)) die("There was a problem with the editor %s.", editor); - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
